-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy loading Google Maps script + maps initialization #44
Conversation
Also, I've kicked TravisCI manually and it run the build on this pull request, with a couple of tests failing: Could you please check it and make sure tests/lints are passing? Thanks! |
Hello @ayastreb, Have a nice day, Gerfaut |
@Gerfaut sorry for the delay! Thanks for contribution, published as v2.4.0! |
Hey @ayastreb, no worries! Great news, thanks a lot! Let me know if I can help to include some examples in the demo site! Have a nice day, Gerfaut |
Hi @Gerfaut , the demo site is built from gh-pages-src branch in this repo, and it's a Jekyll site :) Feel free to submit MR to that branch with changes you'd like to see, although I'm not sure how to show lazy loading on demo site, since it's already has some maps :) |
Hi @ayastreb, I'll submit a PR end of the week probably when it will be ready! Thanks, Gerfaut |
Using Intersection Observer API.
Resolve #36 and optimize LightHouse result.
Let me know what you think 😉
Thanks a lot for this great lib! 👍
Gerfaut