Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy loading Google Maps script + maps initialization #44

Merged
merged 10 commits into from
Apr 19, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 3, 2020

Using Intersection Observer API.
Resolve #36 and optimize LightHouse result.
Let me know what you think 😉

Thanks a lot for this great lib! 👍

Gerfaut

@ayastreb
Copy link
Owner

ayastreb commented Apr 5, 2020

Also, I've kicked TravisCI manually and it run the build on this pull request, with a couple of tests failing:
https://travis-ci.org/github/ayastreb/jekyll-maps/jobs/670898756?utm_medium=notification&utm_source=github_status

Could you please check it and make sure tests/lints are passing?

Thanks!

@ghost
Copy link
Author

ghost commented Apr 10, 2020

Hello @ayastreb,
I fixed / added tests and did a fallback solution for older browsers not supporting IntersectionObserver (tested on IE11 and working).
Let me know if there is anything I can help with 😉

Have a nice day,

Gerfaut

@ayastreb ayastreb merged commit 227cffc into ayastreb:master Apr 19, 2020
@ayastreb
Copy link
Owner

@Gerfaut sorry for the delay!

Thanks for contribution, published as v2.4.0!

@ghost
Copy link
Author

ghost commented Apr 19, 2020

Hey @ayastreb, no worries!

Great news, thanks a lot!
I hope it will please some features requested ;)

Let me know if I can help to include some examples in the demo site!

Have a nice day,

Gerfaut

@ayastreb
Copy link
Owner

Hi @Gerfaut ,

the demo site is built from gh-pages-src branch in this repo, and it's a Jekyll site :)

Feel free to submit MR to that branch with changes you'd like to see, although I'm not sure how to show lazy loading on demo site, since it's already has some maps :)

@ghost
Copy link
Author

ghost commented Apr 20, 2020

Hi @ayastreb,
Thanks for the info!
Indeed lazy loading is already "shown" on the demo website 😄
I'll work on examples for styles (regarding the PR #45) and just add some words about lazy loading / compatibility IE, etc 😉

I'll submit a PR end of the week probably when it will be ready!

Thanks,

Gerfaut

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map load speed
2 participants