aya: feature helpers for kernel capabilities #970
Conversation
❌ Deploy Preview for aya-rs-docs failed.Built without sensitive environment variables
|
…ture trait instead
| // /// Result type used for the feature helpers | ||
| // pub type Result<T> = std::result::Result<T, FeatureError>; | ||
|
|
||
| // fn probe_map_create(map_type: bpf_map_type) -> Result<bool> { |
There was a problem hiding this comment.
I actually like the idea of having a separate features.rs file. Maybe you could file a prerequisite PR, which moves all is_*_supported functions from bpf.rs to features.rs?
I would be also fine with adding is_ringbuf_supported to bpf.rs and doing this refactor later.
But either way, let's do it without adding commented code. :)
There was a problem hiding this comment.
Was actually a mistake making that 2nd commit. I'll probably close this PR since the scope has changed (see chat) and create a new when I have some working code that's in line with the new proposed solution and your comment
|
Scope has changed. Closing this and will create a new later with the proposed suggestions. |
Enables feature detection from user space by trying to create maps and reporting back if it succeeded or not.
This is a better way of determining if the kernel supports e.g. ring buffers by creating a ringbuf map type and checking the result, than by relying on the kernel version.
This could be expanded to many more features such as libbpf does in https://github.com/libbpf/libbpf/blob/master/src/features.c