-
Notifications
You must be signed in to change notification settings - Fork 281
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
WIP: Reduce Explosion of Aya Error Types
I have been down a rabbit hole of cleaning up the aya error types 😅 Most of the important changes are in `errors.rs`. TL;DR Current exposed types are: - `EbpfError` - `ProgramError` - `MapError` - `LinkError` - `PerfBufferError` - `SysError` Honestly I'm still thinking about how we could collapse those types. Either into a single type, or at least fewer than we expose today. Within each of those types, I've tried to remove any invariants that don't have any business being public (e.g if a syscall fails with -EINVAL, there is nothing at runtime you can do about it other than bailing). 👆 (and the spaghetti of errors depending on other errors) are replaced by an `Other` invariant that's a Box<dyn std::error::Error>. There are still some `pub(crate) XInternalError` types, but these are used only to make nice error messages. This could plausibly be replaced with anyhow/context etc.. But I've left it as-is for now. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
- Loading branch information
1 parent
366c599
commit e899c8e
Showing
69 changed files
with
3,230 additions
and
3,848 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.