-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added formatter for localization #207
Conversation
Now targeting frameworks netstandard2.0, netstandard2.1, net461
Reason: Issues with localization resources on AppVeyor with net5.0
Added CLI parameters /p:AltCoverInplace=true /p:AltCoverForce=true
Codecov Report
@@ Coverage Diff @@
## version/v3.0 #207 +/- ##
============================================
+ Coverage 17% 17% +1%
============================================
Files 95 99 +4
Lines 12833 12905 +72
============================================
+ Hits 2146 2224 +78
+ Misses 10687 10681 -6
Continue to review full report at Codecov.
|
Finally found a fix for the failing unit test, since we have embedded resources in the test project. The test now must be invoked with the following additional parameters |
* Added `LocalizationFormatter` * Added `ILocalizationProvider` and a standard implemention as `LocalizationProvider`, which handles `resx` resource files * `SmartSettings` were exended with category `Localization`. * Custom `IFormatter` can now make use of localization, if needed. * New exception type `LocalizationFormattingException` * `FormattingException` now contains `InnerException` where applicable * Updated unit test packages to latest version * Updated appveyor.yml because AltCover made unit tests with resource files fail: Added CLI parameters /p:AltCoverInplace=true /p:AltCoverForce=true
Added features to localize literals and placeholders
LocalizationFormatter
ILocalizationProvider
and a standard implemention asLocalizationProvider
, which handlesresx
resource filesSmartSettings
were exended with categoryLocalization
.IFormatter
can now make use of localization, if needed.LocalizationFormattingException
FormattingException
now containsInnerException
where applicable