Improve HTML processing for placeholders that are using formatting arguments #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…guments - Introduced new test methods `SimpleHtmlContent` and `ConditionalHtmlContent` in `Message_Html.cs`. - Modified `HtmlBodyBuilder` constructor to replace placeholders before parsing HTML to avoid entity encoding issues. - Simplified `ReplaceImgSrcByCid` method in `HtmlBodyBuilder.cs`. - Updated `GetConfiguredMailSmartFormatter` in `MailMergeMessage.cs` to set `ParseInputAsHtml` to `true`. - Corrected typos in comments
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
- Coverage 94.41% 94.40% -0.01%
==========================================
Files 39 39
Lines 1968 1965 -3
==========================================
- Hits 1858 1855 -3
Misses 110 110 ☔ View full report in Codecov by Sentry. |
|
Release v5.12.2 is published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #45
HtmlBodyBuilderconstructor to replace placeholders before parsing HTML to avoid entity encoding issues.ReplaceImgSrcByCidmethod inHtmlBodyBuilder.cs.GetConfiguredMailSmartFormatterinMailMergeMessage.csto setParseInputAsHtmltotrue.SimpleHtmlContentandConditionalHtmlContentinMessage_Html.cs.