playwright feature - #2
Open
ankayca wants to merge 7 commits into
Open
Conversation
…nd browser drivers
Scribd re-shows its reader toolbar (Download/Find bar) when scrolling, so hiding overlays once before the loop left the banner on pages where it overlapped at capture time. Tag fixed/sticky elements before every screenshot and hide them via an !important rule that beats Scribd's inline styles. Co-authored-by: Cursor <cursoragent@cursor.com>
The sticky reader toolbar is re-rendered by Scribd's React app whenever pg.screenshot() re-scrolls a page into view, producing a fresh node without the hide marker, so the banner reappeared on whatever page was in view (e.g. 47, 82). Install a MutationObserver that re-tags every fixed/sticky element on any DOM change so re-rendered overlays are hidden before the screenshot frame is captured. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Script was not working with slides like : https://www.scribd.com/document/928501573/10-Meb-Teskilat-Yapisi
So the problem was scribd block us to read tex fields of slides. I used playwright with chromium to mimic a browser.