XIVY-14079 Fix theme without localstorage usage #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ivy-lli
commented
May 8, 2024
•
ivy-lli
commented
- Add context unit tests
- Disable readonly for table search field
ivy-lli
force-pushed
the
theme-without-storage
branch
from
d29fcb2
to
13b1ff3
Compare
ivy-lli
commented
May 8, 2024
| storageKey = 'ivy-ui-theme', | ||
| storageKey, |
There was a problem hiding this comment.
I think this is the problem for https://1ivy.atlassian.net/browse/XIVY-14090
As soon as you once change the theme in the editor, the localstorage was filled with the 'ivy-ui-theme' property which holds the theme, after that the defaultTheme parameter is no longer respected (e.g. the in the eclipse integration -> theme URL parameter).
Now the localstorage is only used if this parameter is defined.
ivy-lli
force-pushed
the
theme-without-storage
branch
from
13b1ff3
to
ecd2f1a
Compare
ivy-lli
force-pushed
the
theme-without-storage
branch
3 times, most recently
from
f53e3e0
to
fc0c739
Compare
ivy-lli
changed the title
ivy-lli
force-pushed
the
theme-without-storage
branch
from
fc0c739
to
117b72c
Compare
- Add context unit tests - Disable readonly for table search field
ivy-lli
force-pushed
the
theme-without-storage
branch
from
117b72c
to
c0b4da5
Compare
ivy-rew
approved these changes
May 8, 2024
ivy-lli
added a commit
that referenced
this pull request
May 8, 2024
XIVY-14079 Fix theme without localstorage usage #74 > R11.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.