renovate; read slf4j version from properties #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivy-rew
changed the title
ivy-rew
commented
May 23, 2025
|
|
||
| /** must match version in pom.xml */ | ||
| private static final String SLF4J_VERSION = "2.0.13"; | ||
| private static final String SLF4J_VERSION = readSlf4jVersion(); |
Member
Author
There was a problem hiding this comment.
no more manual syncing of versions 👋
Member
Author
|
simplifies by upcoming fix with slf4j downgrading #700 |
alexsuter
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common renovate blocker of the past ... upgrades of slf4j never came for free, as the constant in the code had to be updated manually