Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XIVY-15540 render HTML of javadoc #681

Merged
merged 1 commit into from
Nov 27, 2024
Merged

XIVY-15540 render HTML of javadoc #681

merged 1 commit into from
Nov 27, 2024

Conversation

ivy-rew
Copy link
Member

@ivy-rew ivy-rew commented Nov 27, 2024 •
edited
Loading

brings stiflers mum back on stage

stifflers-mum-data

... no honestly; let's render javadoc HTMLs ... e.g apache commons StringUtils
html-docs

@ivy-rew ivy-rew requested a review from ivy-edp November 27, 2024 11:18
@ivy-rew ivy-rew marked this pull request as ready for review November 27, 2024 11:20
@ivy-rew ivy-rew requested a review from ivy-lli as a code owner November 27, 2024 11:20
ivy-lli
ivy-lli approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@ivy-lli ivy-lli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be safe right? Or better do we have a santisiert which checks this HTML first?

@ivy-rew
Copy link
Member Author

ivy-rew commented Nov 27, 2024

This should be safe right? Or better do we have a santisiert which checks this HTML first?

Honestly I guess this is indeed dangerous. Though I tested manually and couldn't execute descriptions like <script>alert('exposed')</script>
However; I copied this from Function-Browser where it's also in use, so I thought it safe enough to use

@ivy-rew ivy-rew merged commit e76d240 into release/12.0 Nov 27, 2024
10 checks passed
@ivy-rew ivy-rew deleted the XIVY-15540-htmlDoc branch November 27, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivy-lli ivy-lli ivy-lli approved these changes

@ivy-edp ivy-edp Awaiting requested review from ivy-edp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivy-rew @ivy-lli