fix(cliff): improve verification on cliff msg tx

axone-protocol · Oct 5, 2022 · 4dfaa5b · 4dfaa5b
1 parent ea3e2c5
commit 4dfaa5b
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/x/vesting/types/msgs.go b/x/vesting/types/msgs.go
@@ -222,7 +222,7 @@ func NewMsgCreateCliffVestingAccount(fromAddr,
 func (msg MsgCreateCliffVestingAccount) Route() string { return RouterKey }
 
 // Type returns the message type for a MsgCreateVestingAccount.
-func (msg MsgCreateCliffVestingAccount) Type() string { return TypeMsgCreateVestingAccount }
+func (msg MsgCreateCliffVestingAccount) Type() string { return TypeMsgCreateCliffVestingAccount }
 
 // ValidateBasic Implements Msg.
 func (msg MsgCreateCliffVestingAccount) ValidateBasic() error {
@@ -245,6 +245,14 @@ func (msg MsgCreateCliffVestingAccount) ValidateBasic() error {
 		return sdkerrors.Wrap(sdkerrors.ErrInvalidRequest, "invalid end time")
 	}
 
+	if msg.CliffTime <= 0 {
+		return sdkerrors.Wrap(sdkerrors.ErrInvalidRequest, "invalid cliff time")
+	}
+
+	if msg.CliffTime > msg.EndTime {
+		return sdkerrors.Wrap(sdkerrors.ErrInvalidRequest, "cliff time should be before end time")
+	}
+
 	return nil
 }