Filterx switch case #473
Merged
Filterx switch case #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazsi
force-pushed
the
filterx-switch-case
branch
6 times, most recently
from
6fff9da to
933f384
Compare
bazsi
force-pushed
the
filterx-switch-case
branch
2 times, most recently
from
723f2f1 to
8516445
Compare
alltilla
reviewed
Feb 5, 2025
|
Talked with Bazsi IRL, I will finish this PR by fixing the review comments. |
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
May even be extracted into its own module. Right now, it's just a quick and dirty export. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
…specified start index Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
This should bail out from the current compound expression, but not out of the entire filterx block, like "done" or "drop". Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Due to the way our for() loop was organized, the processing for eval_control_modified was not performed for the last element. Make sure it is. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
…r transformations Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
The respective target might only turn into a litaral in optimize, not in the ctor. Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
alltilla
force-pushed
the
filterx-switch-case
branch
from
8516445 to
5945443
Compare
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
alltilla
force-pushed
the
filterx-switch-case
branch
from
5945443 to
1447538
Compare
|
@bazsi Updated the PR according to my review comments. Could you kindly review it? I put an approve to the PR so you can self merge if you are okay with the changes. |
alltilla
approved these changes
Feb 6, 2025
|
The followups all look great. Thanks @alltilla |
fekete-robert
pushed a commit
to axoflow/axosyslog-core-docs
that referenced
this pull request
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for switch-case structure and changes app-parser() to use it.
This sits on top of #465