factor platform code into shared unit #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is draft because:
|
Gankra
commented
May 1, 2024
This is a significantly reduced scope implementation of #793 that takes all the rich info and shoves it back into the shape of ExecutableZipFragment so all the installers can remain the same. However in doing so it introduces much better support for aliases and fallbacks, and centralizes the logic. As a result several missing aliases are added, and fallback is much more maintainable.
mistydemeo
approved these changes
May 2, 2024
| "{{ artifact.target_triples[0] }}") | ||
| echo '{{ aliases[artifact.target_triples[0]] | tojson }}' | ||
| "{{ artifact.target_triple }}") | ||
| echo '{{ aliases[artifact.target_triple] | tojson }}' |
There was a problem hiding this comment.
Just a note that this needs to be rebased on #986 after that's merged.
This was referenced May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a significantly reduced scope implementation of #793 that takes all the rich info and shoves it back into the shape of ExecutableZipFragment so all the installers can remain the same. However in doing so it introduces much better support for aliases and fallbacks, and centralizes the logic.
As a result several missing aliases are added, and fallback is much more maintainable.