-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow specifying binary aliases / links #964
Conversation
ccd9e66
to
135865d
Compare
Tested in my cargodisttest repo: https://github.com/mistydemeo/cargodisttest/releases/tag/v0.2.122 I've tested with shell, Homebrew, and powershell installers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wants a bit more logic up in rust land, I think.
@@ -838,6 +838,123 @@ libcue = "2.3.0" | |||
}) | |||
} | |||
|
|||
#[test] | |||
fn axolotlsay_alias() -> Result<(), miette::Report> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed last week, we should probably prioritize folding these kinds of things into more existing tests rather than adding more and more (both because it makes the diff actually useful, and because these take forever to run).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I agree. Can we do that in a followup, though? I'd like reorganizing our tests to be fairly intentional, which means we can think directly about which tests contain which groups of features instead of it being a byproduct of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mistydemeo a follow up seems good to me- can you file an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: #979
0939ac2
to
12e7441
Compare
454ac28
to
22a085e
Compare
This adds a new feature allowing any binary in an app to be installed under one or more aliases. These aliases will be symbolic links (shell installer, Homebrew) or hardlinks (Windows).
22a085e
to
2cf9702
Compare
This adds support for binary aliases. Developers whose package installs a binary under one name can specify one or more aliases for any of their binaries, and those aliases will be produced by the installers alongside the actual binary. On Linux and macOS, this uses symbolic links; the shell installer simply runs
ln -s
, while the Homebrew installer uses Homebrew's native "symlink under another name" syntax. On Windows, we use hardlinks due limitations with symlinks discussed in #961.The syntax used for this in
Cargo.toml
is broadly similar to what we use for runners:Fixes #961.