fix: more literally disable host --check #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using 'is from a fork' as a proxy for 'should have the secret' but evidently dependabot can make branches on your repo and trigger PR CI that doesn't have secrets. This regresses our ability to do validation that you've set things up right but it's more reliable.
mistydemeo
approved these changes
Jan 23, 2024
| @@ -113,10 +113,11 @@ jobs: | |||
| - id: plan | |||
| run: | | |||
| cargo dist | |||
| {{%- if dispatch_releases %}} ${{ inputs.tag && (inputs.tag != 'dry-run' && format('host --steps=create --tag={0}', inputs.tag) || format('host --steps=create', inputs.tag)) | |||
| {{%- else %}} ${{ !github.event.pull_request && format('host --steps=create --tag={0}', github.ref_name) | |||
| {{%- if dispatch_releases %}} ${{ (inputs.tag && inputs.tag != 'dry-run' && format('host --steps=create --tag={0}', inputs.tag)) | |||
There was a problem hiding this comment.
I feel like the conditionals here are getting complex enough it might be nice to comment on it; if we run into bugs here it'll help us remember our reasoning a little better.
There was a problem hiding this comment.
that's a good call, i'll add some comments in a follow up (rn just wanna get the fix out)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using 'is from a fork' as a proxy for 'should have the secret' but evidently dependabot can make branches on your repo and trigger PR CI that doesn't have secrets. This regresses our ability to do validation that you've set things up right but it's more reliable.