fix: properly upload the "final" dist-manifest to axo releases #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were just uploading the global one, making us drop all local artifacts (they still got *uploaded*, they just weren't in the dist-manifest). Github Releases were still getting the right manifest because the Right manifest would get written to disk immediately after uploading to Axo Releases.
Gankra
changed the title
mistydemeo
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were just uploading the global one, making us drop all local artifacts
(they still got uploaded, they just weren't in the dist-manifest).
Github Releases were still getting the right manifest because the Right
manifest would get written to disk immediately after uploading to Axo Releases.