fix(powershell): replace errors with throw #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistydemeo
force-pushed
the
powershell_fix_errors
branch
from
ec1d1e5 to
1dacf27
Compare
Gankra
requested changes
Dec 18, 2023
| @@ -58,7 +58,7 @@ function Install-Binary($install_args) { | |||
| Initialize-Environment | |||
There was a problem hiding this comment.
ErrorActionPreference no longer should be overriden above and below in this function
mistydemeo
force-pushed
the
powershell_fix_errors
branch
4 times, most recently
from
9c88803 to
5d9ec4d
Compare
Gankra
approved these changes
Dec 18, 2023
Co-authored-by: Aria Beingessner <a.beingessner@gmail.com> Fixes #484.
mistydemeo
force-pushed
the
powershell_fix_errors
branch
from
976ff85 to
dec41f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is correct, and I can't test myself, but this is my interpretation of the proposed fix in #484.
Fixes #484.