Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): add shell to other install location #619

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

mistydemeo
Copy link
Contributor

I managed to miss the other place this gets called.

@mistydemeo mistydemeo requested a review from Gankra November 29, 2023 17:17
@Gankra
Copy link
Contributor

Gankra commented Nov 29, 2023

Oh i thought you were intentionally only adding it to plan -- we actually install it in almost every task now.

I had already been thinking we might want to start factoring out this generic cargo-dist setup logic to some of minijinja's support for template inheritance/importing (although that may require some extra work in the code we have to statically embed templates in our binary): https://docs.rs/minijinja/latest/minijinja/syntax/index.html#-include-

@ashleygwilliams ashleygwilliams self-assigned this Feb 21, 2024
@Gankra Gankra force-pushed the fail-if-installer-fails-for-real branch from 282d623 to c70bc15 Compare February 22, 2024 19:00
@Gankra Gankra merged commit 874eefa into main Feb 22, 2024
15 checks passed
@Gankra Gankra deleted the fail-if-installer-fails-for-real branch February 22, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants