fix(sysdeps): handle empty Linux packages #525
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen a minor UI issue with Linux dependencies. I anticipated catching the error status output from
dpkg -S
and reacting to that, but we were still getting cases where not finding the package and accidentally returning an empty string as the "package". This checks for that case and properly handles it.Before this fix, the linkage reporter was giving us outputs like:
And with this fix, it looks like: