Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sysdeps): handle empty Linux packages #525

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

mistydemeo
Copy link
Contributor

We've seen a minor UI issue with Linux dependencies. I anticipated catching the error status output from dpkg -S and reacting to that, but we were still getting cases where not finding the package and accidentally returning an empty string as the "package". This checks for that case and properly handles it.

Before this fix, the linkage reporter was giving us outputs like:

/path/to/lib ()

And with this fix, it looks like:

/path/to/lib

We've seen a minor UI issue with Linux dependencies. I anticipated catching
the error status output from `dpkg -S` and reacting to that, but we were
still getting cases where not finding the package and accidentally
returning an empty string as the "package". This checks for that case and
properly handles it.
@mistydemeo mistydemeo requested a review from Gankra October 26, 2023 20:46
@mistydemeo
Copy link
Contributor Author

Confirmed this works.

╞════════════════════╪════════════════════════════════════════════════════════════════════════════════╡
│ System             ┆ /usr/lib/aarch64-linux-gnu/libgtk-3.so.0.2404.29 (libgtk-3-0)                  │
│                    ┆ /usr/lib/aarch64-linux-gnu/libgobject-2.0.so.0.7200.4 (libglib2.0-0)           │
│                    ┆ /usr/lib/aarch64-linux-gnu/libstdc++.so.6.0.30 (libstdc++6)                    │
│                    ┆ /usr/lib/aarch64-linux-gnu/libgcc_s.so.1                                       │

@mistydemeo mistydemeo merged commit 8c13c45 into main Oct 30, 2023
@mistydemeo mistydemeo deleted the linux-improve-output branch October 30, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants