fix(linkage): improve apt package resolution #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i'm not qualified to review this- @Gankra can you take a look today? |
The path linked against might be a symlink that `dpkg -S` can't resolve to the providing package. If we do a `realpath` call on it, we get a path that we can more reliably resolve later.
mistydemeo
force-pushed
the
ldd-fix-package-resolution
branch
from
53f4dd7 to
53c9870
Compare
Gankra
approved these changes
Oct 23, 2023
mistydemeo
added a commit
that referenced
this pull request
Oct 23, 2023
fix(linkage): improve apt package resolution
mistydemeo
added a commit
that referenced
this pull request
Oct 23, 2023
fix(linkage): improve apt package resolution
mistydemeo
added a commit
that referenced
this pull request
Oct 23, 2023
fix(linkage): improve apt package resolution
mistydemeo
added a commit
that referenced
this pull request
Oct 23, 2023
fix(linkage): improve apt package resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path linked against might be a symlink that
dpkg -Scan't resolve to the providing package. If we do arealpathcall on it, we get a path that we can more reliably resolve later.