Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add create-release config to allow people to draft their own releases #367

Merged
merged 1 commit into from
Aug 28, 2023
Merged

feat: add create-release config to allow people to draft their own releases #367

merged 1 commit into from
Aug 28, 2023

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Aug 25, 2023 •
edited by ashleygwilliams
Loading

fixes #366

@ashleygwilliams ashleygwilliams mentioned this pull request Aug 25, 2023
Merged
@ashleygwilliams ashleygwilliams changed the title feat: add edit-existing config to allow people to draft their own PRs feat: add edit-existing config to allow people to draft their own releases Aug 25, 2023
@Gankra
Copy link
Contributor Author

Gankra commented Aug 25, 2023

Test change: oranda-gallery/cargodisttest@bf613c9

Test release: https://github.com/oranda-gallery/cargodisttest/actions/runs/5978340652/job/16220216455

@Gankra
Copy link
Contributor Author

Gankra commented Aug 25, 2023

Successful Result: https://github.com/oranda-gallery/cargodisttest/releases/tag/v0.3.58

@ashleygwilliams ashleygwilliams self-assigned this Aug 25, 2023
@ashleygwilliams ashleygwilliams added this to the 0.2.0 milestone Aug 25, 2023
ashleygwilliams
ashleygwilliams approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do docs later, would like a pre-release of this today

mistydemeo
mistydemeo approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@mistydemeo mistydemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I think the suggestion of swapping to create_release is a good idea.

@Gankra
feat: add create-release config to allow people to opt out
4ad7916 
create-release = false lets you draft the Github Release ahead of time,
and we'll just edit + undraft it.
@Gankra Gankra changed the title feat: add edit-existing config to allow people to draft their own releases feat: add create-release config to allow people to draft their own releases Aug 28, 2023
@Gankra Gankra merged commit 2e00814 into main Aug 28, 2023
@Gankra Gankra deleted the assume-release branch August 28, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistydemeo mistydemeo mistydemeo approved these changes

@ashleygwilliams ashleygwilliams ashleygwilliams approved these changes

Assignees

@ashleygwilliams ashleygwilliams

Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

create way to turn off release creation
3 participants
@Gankra @mistydemeo @ashleygwilliams