feat: restore release table headings, add platform #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistydemeo
force-pushed
the
column_headers
branch
2 times, most recently
from
375d997 to
2690f8f
Compare
|
Switching to draft while it's using a prerelease axoproject. |
Gankra
approved these changes
Aug 25, 2023
Comment on lines
-1811
to
+1819
| gh_body.push_str("| | |\n"); | ||
| gh_body.push_str("|--------|--------|\n"); | ||
| gh_body.push_str("| File | Platform | Checksum |\n"); | ||
| gh_body.push_str("|--------|----------|----------|\n"); |
There was a problem hiding this comment.
huh interesting, I apparently didn't make this code tolerant of the fact that checksums can be disabled. Whelp, pre-existing issue.
mistydemeo
force-pushed
the
column_headers
branch
from
2690f8f to
018fb50
Compare
mistydemeo
force-pushed
the
column_headers
branch
from
018fb50 to
c631551
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings back column headings that had been removed in 0.1.0, and adds an extra platform column.
Right now those are displayed as triples rather than as the human-formatted ones that oranda uses.They're now printed as pretty human-readable names like oranda!Fixes #356.