fix: unreachable code in installer.sh template #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellcheck rule SC2317: https://www.shellcheck.net/wiki/SC2317 This was introduced in shellcheck 0.9.0 which explains why it wasn't seen in CI because it uses shellcheck 0.8.0 (because that's what's packaged in Ubuntu 22.04). Fixes axodotdev#344
Gankra
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
whitespace cleanups appreciated (I had whitespace auto-removal disabled in my editor for a bit due to some policies on other things I worked on, I've since added it back)
also the assertion_line thing is just a weird artifact from cargo-insta making a change to how they manage snapshots, so those lines flicker in and out of existence based on which version of the CLI someone has installed iirc (so it's fine).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shellcheck rule SC2317:
https://www.shellcheck.net/wiki/SC2317
This was introduced in shellcheck 0.9.0 which explains why it wasn't seen in CI because it uses shellcheck 0.8.0 (because that's what's packaged in Ubuntu 22.04).
Fixes #344 (issue also has some more shellcheck details)
Incidentally this PR also includes some whitespace cleanup that my editor decided to perform. Let me know if that is undesired and I'll revert those!
Also, I'm not sure what
assertion_lineis or why it was removed in the updated insta snapshots?