feat(install-path): add install-path config #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes the way we handle parse errors or dist-metadata (before we would just replace corrupt values with Default, which, is confusing). Possible values include: * "CARGO_HOME": install to the user's cargo bins (default) * "~/some/subdir": install to the given subdir of the user's home dir * "$ENV_VAR/some/subdir": install to the given subdir of the given env var Examples: "~/.my-app", "$MY_APP/", "$MY_APP/bin/" If the resulting path doesn't exist, a directory will be created at its location. All 3 of these settings will error out if required env vars aren't set: * "CARGO_HOME": first tries $CARGO_HOME, then $HOME * "~/subdir": tries $HOME * "$ENV_VAR/subdir": tries $ENV_VAR (Note that $HOME/subdir is technically valid syntax, but won't behave the way you want, because in powershell $HOME isn't a normal env var. Use `~/subdir` and we'll handle these details for you.)
This script is descended from rustup.sh, and they have way more people cleaning it up, so let's snag the improvements. * add shellcheck annotation (and fix issues) * update platform detection * properly handle variable detection with `set -u`
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #235 and the most important part of #41
Also fixes the way we handle parse errors or dist-metadata (before we would just replace corrupt values with Default, which, is confusing).
Possible values include:
Examples: "~/.my-app", "$MY_APP/", "$MY_APP/bin/"
If the resulting path doesn't exist, a directory will be created at its location.
All 3 of these settings will error out if required env vars aren't set:
(Note that $HOME/subdir is technically valid syntax, but won't behave the way you want,
because in powershell $HOME isn't a normal env var. Use
~/subdirand we'll handle thesedetails for you.)