fix: make linkage truly infallible #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also some driveby cleanups
| @@ -215,7 +215,7 @@ impl BuildExpectations { | |||
| }); | |||
| linkage | |||
| } else { | |||
| determine_linkage(src_path, target)? | |||
| determine_linkage(src_path, target) | |||
There was a problem hiding this comment.
this is the diff i was looking for haha
| file_name: Option<String>, | ||
| }, | ||
| #[error("unable to run linkage report for this type of binary")] | ||
| LinkageCheckUnsupportedBinary, |
There was a problem hiding this comment.
i do think maintaining the name of the file would be useful
There was a problem hiding this comment.
The warning all of these flow into handles reporting the filename so it ends up being redundant noise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also some driveby cleanups