Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve powershell installer portability #1373

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix: improve powershell installer portability #1373

merged 1 commit into from
Aug 28, 2024

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Aug 27, 2024

  • pass -ExecutionPolicy ByPass to run on default-security windows installs
  • clarify restart system instead of shell
  • suggest an expr for fixing the current session

@Gankra
Copy link
Contributor Author

Gankra commented Aug 27, 2024 •
edited
Loading

currently draft because the expr is a WIP placeholder -- need to settle on a final one.

@Gankra
fix: improve powershell installer portability
a9b615b 
* pass -ExecutionPolicy ByPass to run on default-security windows installs
* clarify restart system instead of shell
* suggest an expr for fixing the current session
@Gankra Gankra marked this pull request as ready for review August 27, 2024 20:01
mistydemeo
mistydemeo approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@mistydemeo mistydemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to ensure that axoupdater provides the same argument to powershell?

@Gankra
Copy link
Contributor Author

Gankra commented Aug 27, 2024

It should, yes.

@Gankra Gankra merged commit 39f96b3 into main Aug 28, 2024
16 checks passed
@Gankra Gankra deleted the psup branch August 28, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistydemeo mistydemeo mistydemeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gankra @mistydemeo