Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: random error/prompt cleanups #1360

Merged
merged 2 commits into from
Aug 26, 2024
Merged

fix: random error/prompt cleanups #1360

merged 2 commits into from
Aug 26, 2024

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Aug 22, 2024

@Gankra
Copy link
Contributor Author

Gankra commented Aug 22, 2024

the first commit has some stubbed out code I need to turn into Real Errors and not fake macros

@Gankra Gankra marked this pull request as ready for review August 26, 2024 16:47
mistydemeo
mistydemeo approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@mistydemeo mistydemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor things I noticed.

cargo-dist/src/errors.rs Outdated Show resolved Hide resolved
cargo-dist/src/errors.rs Show resolved Hide resolved
@Gankra Gankra merged commit c92b9a1 into main Aug 26, 2024
16 checks passed
@Gankra Gankra deleted the cleanup-errs branch August 26, 2024 17:49
@Gankra Gankra mentioned this pull request Aug 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistydemeo mistydemeo mistydemeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Gankra @mistydemeo