fix: parsing multiline brew output #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistydemeo
force-pushed
the
brew_fix_env_parsing
branch
from
c9a5d0c
to
f94782e
Compare
Gankra
approved these changes
Aug 20, 2024
Gankra
reviewed
Aug 20, 2024
The `brew bundle exec -- /usr/bin/env` output now contains multiline strings, which I should always have been guarding against anyway. This updates us to use the `-0` option to `env`, which separates lines in the output by nul bytes instead of newlines - that way we can more safely parse the output of environment variables containing newlines.
mistydemeo
force-pushed
the
brew_fix_env_parsing
branch
from
f94782e
to
0344954
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
brew bundle exec -- /usr/bin/envoutput now contains multiline strings, which I should always have been guarding against anyway. This updates us to use the-0option toenv, which separates lines in the output by nul bytes instead of newlines - that way we can more safely parse the output of environment variables containing newlines.