release: 0.19.1 #1206
Closed
release: 0.19.1 #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had cdylibs available from axoproject/`cargo metadata` in the past, but we ignored them. This pipes them into the buildsystem and treats them as binaries like any others. For most of the layers of cargo-dist, we have a single set of "binaries" but we now type them so that we can keep track of which are executables and which are libraries. We separate them back out at the time that we create installers to simplify the process of deciding where they get installed to. By default, these aren't packaged or installed in order to avoid catching people by surprise. However, they can be enabled easily via the new `package-cdylibs` and `install-cdylibs` config flags. Homebrew has full first-class support for libraries, which we use here. Shell and PowerShell currently install them to the same path as binaries; this will change with new default prefixes in the future. npm projects don't change since they never did any form of organized installation, and just dumped the entire contents of the release tarball into a private path.
Support cdylibs from Rust/generic projects
This introduces a new axoproject WorkspaceGraph abstraction that exists to replace the old Workspaces approach. The purpose of this new abstraction is that it supports nested workspaces, while still allowing you to work with all the packages uniformly. Most code largely remains the same, as it looks up properties of packages by id, or queries a property of all workspaces/packages, where essentially nothing is changed. Also all logic to inherit config from workspaces to packages is just changed to inherit from the *root* package, as we don't want to support multiple `[workspace.metadata.dist]` entries. compute_build functions have been changed to take a workspace, so that we try to compute N cargo builds for N cargo workspaces (discarding them if unecessary). The URL code has once again been refactored to be more of a chain instead of redoing the same work over and over. The `package_info` subfield of a workspace has been deprecated in favour of Asking the WorkspaceGraph, as there are different tiers of childhood now.
feat: shared workspaces
ashleygwilliams
approved these changes
Jul 12, 2024
| @@ -3,6 +3,11 @@ | |||
| Nothing Yet! | |||
|
|
|||
|
|
|||
| # Version 0.19.1 (2024-07-12) | |||
|
|
|||
| This is a minor release that makes cargo-dist build with versions of rustc older than 1.79.0 (as of this writing, the latest release). The previous cargo-dist release accidentally relied on the rustc's [new temporary lifetime extension features](https://blog.rust-lang.org/2024/06/13/Rust-1.79.0.html#extending-automatic-temporary-lifetime-extension), making us suddenly require bleeding edge rustc for no good reason. | |||
There was a problem hiding this comment.
word minor here might be confusing but otherwise lgtm
|
(for merge conflict reasons i opened two PRs using the same base branch but different merge-target branches, this is the "doomed" PR that had working CI but went to a dummy branch. the other PR will be merged) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1204