fix: handle Invoke-Installer errors #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistydemeo
force-pushed
the
fix-ps1-errors
branch
from
3fcde17
to
6c8f055
Compare
Gankra
approved these changes
Jul 10, 2024
I tested by reproducing the empty artifact, looks like I accidentally swallowed the original error message. I'll fix that. |
We hadn't set the error types we wanted from the core file management functions here, so they were continuing after an error instead of throwing so we could terminate early. Prior to dec41f6 this was handled by explicitly setting $ErrorActionPreference before and after calling Invoke-Installer. We removed that when reworking some errors, but we didn't update individual calls within Invoke-Installer to ensure they still stopped on error.
mistydemeo
force-pushed
the
fix-ps1-errors
branch
from
6c8f055
to
eed524b
Compare
|
We already have a global try-catch on the script, not clear what adding this extra interim catch does, tbh |
|
Yeah, fair enough. I can drop it, just felt that a little extra info on what step failed gives more context on the exception. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hadn't set the error types we wanted from the core file management functions here, so they were continuing after an error instead of throwing so we could terminate early.
Prior to dec41f6 this was handled by explicitly setting
$ErrorActionPreferencebefore and after callingInvoke-Installer. We removed that when reworking some errors, but we didn't update individual calls within Invoke-Installer to ensure they still stopped on error.Fixes #1183.