fix: write correct install prefix to receipt #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistydemeo
force-pushed
the
fix-receipt-install-prefix
branch
2 times, most recently
from
8adb63d to
de16b79
Compare
mistydemeo
force-pushed
the
fix-receipt-install-prefix
branch
from
de16b79 to
5df4fd6
Compare
Gankra
approved these changes
May 14, 2024
Gankra
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue introduced in 91ac6af, where
/binwas always added to this even though the updater expected it to be a root prefix instead. We can then tighten up the special handling around normalizing the root in axodotdev/axoupdater#109, which currently gets confused between whether a directory should end in/binor if it's a cargo home-style path that shouldn't.