Skip to content

Fix issue #1546 of UILayout #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 27, 2023
Merged

Fix issue #1546 of UILayout #1549

merged 3 commits into from
Dec 27, 2023

Conversation

aismann
Copy link
Contributor

@aismann aismann commented Dec 27, 2023

Which branch your pull-request should merge into?

  • dev: Current 2.x BugFixs or Features

Describe your changes

Fix issue #1546
Wrong use of DrawNode::drawPolygon changed to DrawNode::drawSolidRect

Issue ticket number and link

Fix issue #1546

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I have checked readme and add important infos to this PR (if it needed).
  • I have added/adapted some tests too.

@halx99 halx99 linked an issue Dec 27, 2023 that may be closed by this pull request
Crashes only in iPads/live afther - Fix/enhancement for issue #1319 (draw filled complex polygons (concave/convex) #1546
Closed
@aismann
Copy link
Contributor Author

aismann commented Dec 27, 2023

can be merged now

@halx99 halx99 added this to the 2.1.0-LTS milestone Dec 27, 2023
@halx99 halx99 added bug Something isn't working cocos2dx The issue present in original cocos2dx labels Dec 27, 2023
@halx99 halx99 changed the title Update UILayout.cpp => Fix issue #1546 Fix issue #1546 of UILayout Dec 27, 2023
@halx99 halx99 merged commit 54daf35 into axmolengine:dev Dec 27, 2023
@aismann aismann mentioned this pull request Dec 30, 2023
Merged
5 tasks
halx99 pushed a commit that referenced this pull request Dec 31, 2023
@aismann
Fix issue #1546 of UILayout(#1549) and small performance boost (#1559)
c389118 
* Fix issue #1546 of UILayout(#1549) and small performance boost

* add test

* Committing genbindings changes

---------

Co-authored-by: aismann <aismann@users.noreply.github.com>
halx99 pushed a commit that referenced this pull request Jan 3, 2024
@aismann
Update DrawPrimitivesTest.cpp (Smaller tester code) (#1572)
bf4a6a0 
* Fix issue #1546 of UILayout(#1549) and small performance boost

* add test

* Update DrawPrimitivesTest.cpp (Smaller tester code)
halx99 pushed a commit that referenced this pull request May 22, 2024
@aismann
DrawNodeEx/DrawNodeExTest update (#1914)
5b8a074 
* Fix issue #1546 of UILayout(#1549) and small performance boost

* add test

* Update DrawPrimitivesTest.cpp (Smaller tester code)

* Update DrawNodeEx.h

AX_EX_DLL

* Update AXLinkHelpers.cmake

* Update Console.cpp (removed the '\n' which creates an second (empty) line)

* segment stuff

* .

* add some more tests

* Issue  1888

* .

* add all DrawNode cocos2dx

* .

* .

* .

* add feature for drawing in correct order

* .

* Update DrawNodeEx.cpp

* .

* Update DrawNodeEx.cpp

* DRAWNODE_TRIANGLE_ONLY

* DRAWNODE_DRAW_LINE_POINT

* .

* Update DrawNodeExTest.cpp

* Update DrawNodeExTest.cpp

* .

* .

* Add round brackets

* commendet this both lines (check it in next version)

* .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halx99 halx99 halx99 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cocos2dx The issue present in original cocos2dx
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Crashes only in iPads/live afther - Fix/enhancement for issue #1319 (draw filled complex polygons (concave/convex)
2 participants
@aismann @halx99