axmol compilation fails with C++23 - it looks like real bug in the code

[crazyhappygame]

• axmol version: latest
• devices test on: all
• developing environments
  • NDK version: r23c
  • Xcode version: 14.2+
  • Visual Studio:
    • VS version: 2022 (17.9+)
    • MSVC version: 19.39+
    • Windows SDK version: 10.0.22621.0+
  • cmake version:
    Steps to Reproduce:

branch: dev
#2414
branch: v3
#2413

Sample error:

C/C++: /home/runner/work/axmol/axmol/core/base/Logging.cpp:160:12: error: non-const lvalue reference to type 'LogItem' cannot bind to a temporary of type 'LogItem'
C/C++:   160 |     return item;

[crazyhappygame]

It looks like:

AX_API LogItem& preprocessLog(LogItem&& item)

Should be changed to

AX_API LogItem& preprocessLog(LogItem& item)

[crazyhappygame]

@halx99 FYI
Still does not work on both branch dev and wip-v3
#2418
#2419
Can we reopen this ticket?

BTW. What do you think about C++23 by default for axmol?

[halx99]

@halx99 FYI Still does not work on both branch dev and wip-v3 #2418 #2419 Can we reopen this ticket?

BTW. What do you think about C++23 by default for axmol?

Not good current, at least wait until year 2026 I think, and 2.x branch should stay on C++20.

[halx99]

Now fixed, see #2417

NOTE: don't try enable c++23 on dev branch, the ndk-r23d in dev branch not support c++23

[crazyhappygame]

Thank you for fixing and answer.
In my apps I use ndk-r27 I think I will try 2.4.1 and C++23.

Regarding to C++23 support it is not look bad:
https://en.cppreference.com/w/cpp/compiler_support/23
Maybe we can try V3 and C++23?