Fixed The timeoutErrorMessage property in config not work with Node.js (fixes #3580)

[duibu05]

This PR fixes #3580, the issue is that when send axios request in Node.js contains timeout, timeoutErrorMessage properties in config then fired timeout, the error message is not the customized timeoutErrorMessage but "timeout of *ms exceeded". This PR fixes that problem.

[djs113]

Isn't is better to declare var timeoutErrorMessage = '' first then check if config has a timeoutErrorMessage property and if so assign it this value, else the default time out error message should be displayed. This will ensure that the default message is not unnecessarily created if config already has the error message.

var timeoutErrorMessage = '';
if (config.timeoutErrorMessage) {
  timeoutErrorMessage = config.timeoutErrorMessage;
} else {
  timeoutErrorMessage = 'timeout of ' + timeout + 'ms exceeded';
}

[duibu05]

Isn't is better to declare var timeoutErrorMessage = '' first then check if config has a timeoutErrorMessage property and if so assign it this value, else the default time out error message should be displayed. This will ensure that the default message is not unnecessarily created if config already has the error message.

var timeoutErrorMessage = '';
if (config.timeoutErrorMessage) {
  timeoutErrorMessage = config.timeoutErrorMessage;
} else {
  timeoutErrorMessage = 'timeout of ' + timeout + 'ms exceeded';
}

@daniel-julius-sam done

[djs113]

Please link this PR to the relevant issue by including fixes #3580 in the PR description.

[djs113]

That's not what I meant, you should add fixes #3580 exactly in the main message describing this PR just beneath the title, so that it gets linked to the issue it solves. Like how I have done in this PR. https://github.com/axios/axios/pull/3961#partial-pull-merging

[duibu05]

@djs113 Got it, already updated. Please approve this workflow.

[djs113]

I'm not a mainainer, @jasonsaayman please approve this.

[jasonsaayman]

@duibu05 please can you mend the conflict?

[duibu05]

@duibu05 please can you mend the conflict?

@jasonsaayman done