Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Axiom Cloudwatch Forwarder #74

Merged
merged 9 commits into from
Jul 26, 2024
Merged

Conversation

dasfmi
Copy link
Collaborator

@dasfmi dasfmi commented Jul 26, 2024

This PR revises the naming of CloudFormation stack elements to make their purpose clearer, and allows greater flexibility in filtering log groups that are applied as subscription filters to the (newly named) Lambda Forwarder, now using a combination of names, prefix and regular expression. It also introduces versioning to the CloudFormation stacks so breaking changes do not impact users, and introduces a new Unsubscriber stack for convenience.

TODO:

  • Renames the Ingester to Forwarder, Backfiller to Subscriber and the LogsSubscriber to LogGroupsListener.
  • Moves the stack templates to their own folder to improve readability with shorter file names
  • Moves out the responsibility of creating log group subscription filters and gives it to the Subscriber component
  • Subscriber component to handle different inputs for log groups selection (names list, prefix or regex pattern)
  • Create Unsubscriber component
  • Versioning the released stack templates
  • Prefix the created log groups names with /aws/axiom to easily discard them from being forwarded

@dasfmi dasfmi requested a review from a-khaledf July 26, 2024 15:39
@dasfmi dasfmi mentioned this pull request Jul 26, 2024
9 tasks
The Subscriber will override the subscription filter if already exists
Copy link
Member

@dominicchapman dominicchapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. LGTM 👍

@dasfmi dasfmi merged commit de73791 into main Jul 26, 2024
2 checks passed
@dasfmi dasfmi deleted the islam/axiom-4385-rework-the-stacks branch July 26, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants