Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core, trie: rework trie database #585

Conversation

Francesco4203
Copy link
Contributor

@Francesco4203 Francesco4203 commented Sep 26, 2024

Reference: ethereum/go-ethereum#26813

This PR generalize the trie database for later use of Verkle Tree

Some changes:

  • database.go: cacheNode no longer stores node as a whole node, but the encoded bytes instead
  • database.go: move resolver logic to committer, since it is specific for MPT
  • trie_reader.go: only provide retrieving encoded node now

Copy link
Collaborator

@huyngopt1994 huyngopt1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huyngopt1994 huyngopt1994 merged commit ce96bb2 into axieinfinity:path-base-implementing Sep 30, 2024
1 check passed
Francesco4203 added a commit that referenced this pull request Oct 17, 2024
huyngopt1994 pushed a commit that referenced this pull request Oct 25, 2024
huyngopt1994 pushed a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants