consortium-v2: fix wrong parenthesis placement in non-epoch block check #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minh-bq
force-pushed
the
fix/validator-extradata
branch
from
6acd24e to
93f8ed6
Compare
Fix wrong parenthesis placement in non-epoch block check in verifyValidatorFieldsInExtraData which leads to incorrect check result.
minh-bq
force-pushed
the
fix/validator-extradata
branch
from
93f8ed6 to
9e8637e
Compare
huyngopt1994
approved these changes
Jun 13, 2024
andicrypt
approved these changes
Jun 14, 2024
andicrypt
pushed a commit
to andicrypt/ronin
that referenced
this pull request
Aug 14, 2024
…ck (axieinfinity#470) * consortium-v2: make error in verifyValidatorFieldsInExtraData more verbose * consortium-v2: add more unit tests for verifyValidatorFieldsInExtraData * consortium-v2: fix wrong parenthesis placement in non-epoch block check Fix wrong parenthesis placement in non-epoch block check in verifyValidatorFieldsInExtraData which leads to incorrect check result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix wrong parenthesis placement in non-epoch block check in verifyValidatorFieldsInExtraData which leads to incorrect check result.