refactor: add config params to stellar network for finality #499
+35
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blockchainguyy |
milapsheth
reviewed
Jan 14, 2025
| @@ -630,6 +630,9 @@ | |||
| "horizonRpc": "https://horizon-testnet.stellar.org", | |||
| "networkType": "testnet", | |||
| "chainType": "stellar", | |||
| "decimals": 7, | |||
| "finality": "1", | |||
There was a problem hiding this comment.
@blockchainguyy Can you share your research on the finality mechanism? Since it's a critical piece, we should validate
Comment on lines
+1897
to
+1901
| "explorer": { | ||
| "name": "Stellar Expert", | ||
| "url": "https://stellar.expert/explorer/testnet" | ||
| }, | ||
| "tokenSymbol": "XLM" |
There was a problem hiding this comment.
perhaps move these before contracts key, so they're easier to spot (same elsewhere)
milapsheth
reviewed
Jan 14, 2025
| "decimals": 7, | ||
| "finality": "1", | ||
| "contracts": { | ||
| "AxelarGateway": {} |
There was a problem hiding this comment.
I don't like adding an empty contract field. Makes it more confusing when testing if a contract config is present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://axelarnetwork.atlassian.net/browse/AXE-7116