-
Notifications
You must be signed in to change notification settings - Fork 3
v3.0.0 #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps the npm_and_yarn group with 2 updates in the / directory: [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) and [@vitest/coverage-v8](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-v8). Updates `vitest` from 1.3.0 to 1.6.1 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Commits](https://github.com/vitest-dev/vitest/commits/v1.6.1/packages/vitest) Updates `@vitest/coverage-v8` from 1.3.0 to 1.6.1 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Commits](https://github.com/vitest-dev/vitest/commits/v1.6.1/packages/coverage-v8) --- updated-dependencies: - dependency-name: vitest dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: "@vitest/coverage-v8" dependency-type: direct:development dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @ozziest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces v3.0.0 of the validator library, primarily focusing on a critical breaking change that renames the in and isIn validation rules to includes and isIncludes. This change not only resolves a long-standing bug related to declarative rule validation but also eliminates conflicts with JavaScript's reserved keywords, enhancing the library's robustness. Concurrently, the documentation has undergone a comprehensive overhaul, improving user experience with a new dark theme, interactive examples, and a dedicated blog, alongside general dependency updates to ensure a modern and maintainable codebase.
Highlights
- Breaking Change: Rule Renaming: The
inandisInvalidation rules have been renamed toincludesandisIncludesrespectively, to avoid conflicts with JavaScript reserved keywords and improve clarity. This also applies to string rule formats (e.g.,in:admin,moderatorbecomesincludes:admin,moderator). - Bug Fix: Addresses an issue (#73) where the declarative usage of the
in:A,Brule (nowincludes:A,B) did not correctly validate the second value. - Documentation Overhaul: The project documentation has been significantly improved, including a new dark theme, updated homepage content with detailed examples, a blog section, and a new system for animating code blocks and language lists.
- Dependency Updates & Codebase Refinement: Various development dependencies across the main project and documentation have been updated (e.g., VitePress, Sass, Babel presets). Additionally, many test files have been restructured and moved for better organization.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces version 3.0.0, which includes significant breaking changes by renaming the in and isIn rules to includes and isIncludes respectively to avoid conflicts with JavaScript reserved keywords. The changes are consistently applied across the codebase, including documentation, internationalization files, and tests. The documentation has also been greatly improved with a new homepage design and a blog.
| }; | ||
| ``` | ||
|
|
||
| ::: code-group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|



3.0.0 (2025-07-13)
Breaking changes
Rename rule names:
in→includesisIn→isIncludesString rules:
in:admin,moderator→includes:admin,moderatorFixes
Improvements