Avoid object slicing when deriving from Series class (openPMD#1107)

* Make Series class final * Use private constructor to avoid object slicing
ax3l · Nov 3, 2021 · bea0c0c · bea0c0c
1 parent a52966b
commit bea0c0c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/include/openPMD/Series.hpp b/include/openPMD/Series.hpp
@@ -478,6 +478,9 @@ class Series : public SeriesInterface
 private:
     std::shared_ptr< internal::SeriesInternal > m_series;
 
+    // constructor from private parts
+    Series( std::shared_ptr< internal::SeriesInternal > );
+
 public:
     explicit Series();
 

diff --git a/src/Series.cpp b/src/Series.cpp
@@ -1475,6 +1475,15 @@ SeriesInternal::~SeriesInternal()
 }
 } // namespace internal
 
+Series::Series( std::shared_ptr< internal::SeriesInternal > series_in )
+    : SeriesInterface{
+        series_in.get(),
+        static_cast< internal::AttributableData * >( series_in.get() ) }
+    , m_series{ std::move( series_in ) }
+    , iterations{ m_series->iterations }
+{
+}
+
 Series::Series() : SeriesInterface{ nullptr, nullptr }, iterations{}
 {
 }
@@ -1517,7 +1526,9 @@ Series::operator bool() const
 
 ReadIterations Series::readIterations()
 {
-    return { *this };
+    // Use private constructor instead of copy constructor to avoid
+    // object slicing
+    return { this->m_series };
 }
 
 WriteIterations