Clang-tidy CI test: add almost all missing bugprone clang-tidy checks (…

…ECP-WarpX#4064)

* add almost all missing bugprone checks in clang-tidy CI test

* disable bugprone-misplaced-widening-cast check

* fix issue of type bugprone-integer-division

.clang-tidy

@@ -8,6 +8,57 @@ Checks: '-*,
     bugprone-dangling-handle,
     bugprone-dynamic-static-initializers,
     -bugprone-easily-swappable-parameters,
+    bugprone-exception-escape,
+    bugprone-fold-init-type,
+    bugprone-forward-declaration-namespace,
+    bugprone-forwarding-reference-overload,
+    -bugprone-implicit-widening-of-multiplication-result,
+    bugprone-inaccurate-erase,
+    bugprone-incorrect-roundings,
+    bugprone-infinite-loop,
+    bugprone-integer-division,
+    bugprone-lambda-function-name,
+    bugprone-macro-parentheses,
+    bugprone-macro-repeated-side-effects,
+    bugprone-misplaced-operator-in-strlen-in-alloc,
+    bugprone-misplaced-pointer-arithmetic-in-alloc,
+    -bugprone-misplaced-widening-cast,
+    bugprone-move-forwarding-reference,
+    bugprone-multiple-statement-macro,
+    bugprone-no-escape,
+    bugprone-not-null-terminated-result,
+    bugprone-parent-virtual-call,
+    bugprone-posix-return,
+    bugprone-redundant-branch-condition,
+    bugprone-reserved-identifier,
+    bugprone-signal-handler,
+    bugprone-signed-char-misuse,
+    bugprone-sizeof-container,
+    bugprone-sizeof-expression,
+    bugprone-spuriously-wake-up-functions,
+    bugprone-string-constructor,
+    bugprone-string-integer-assignment,
+    bugprone-string-literal-with-embedded-nul,
+    bugprone-stringview-nullptr,
+    bugprone-suspicious-enum-usage,
+    bugprone-suspicious-include,
+    bugprone-suspicious-memory-comparison,
+    bugprone-suspicious-memset-usage,
+    bugprone-suspicious-missing-comma,
+    bugprone-suspicious-semicolon,
+    bugprone-suspicious-string-compare,
+    bugprone-swapped-arguments,
+    bugprone-terminating-continue,
+    bugprone-throw-keyword-missing,
+    bugprone-too-small-loop-variable,
+    bugprone-undefined-memory-manipulation,
+    bugprone-undelegated-constructor,
+    bugprone-unhandled-exception-at-new,
+    bugprone-unhandled-self-assignment,
+    bugprone-unused-raii,
+    bugprone-unused-return-value,
+    bugprone-use-after-move,
+    bugprone-virtual-near-miss,
     cppcoreguidelines-avoid-goto,
     misc-const-correctness,
     modernize-avoid-bind,

Source/Utils/Parser/ParserUtils.cpp

@@ -43,7 +43,8 @@ namespace {
         // (2.0*(numeric_limits<int>::max()/2+1)) converts numeric_limits<int>::max()+1 to a real ensuring accuracy to all digits
         // This accepts x = 2**31-1 but rejects 2**31.
         using namespace amrex::literals;
-        constexpr amrex::Real max_range = (2.0_rt*static_cast<amrex::Real>(std::numeric_limits<int_type>::max()/2+1));
+        constexpr int_type half_max_plus_one = std::numeric_limits<int_type>::max()/2+1;
+        constexpr amrex::Real max_range = (2.0_rt*static_cast<amrex::Real>(half_max_plus_one));
         if (x < max_range) {
             if (std::ceil(x) >= std::numeric_limits<int_type>::min()) {
                 result = static_cast<int_type>(x);