Add option to set a property prefix on Secrets Manager property sources for 2.4.x #630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snigdhasjg
requested review from
MatejNedic and
maciejwalkowiak
as code owners
github-actions
bot
added
component: secrets-manager
maciejwalkowiak
approved these changes
Jan 18, 2023
MatejNedic
approved these changes
Jan 21, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Option to add a prefix to property keys configure
spring.config.importproperty with?prefix=added to the secret name💡 Motivation and Context
When multiple secrets containing JSON properties are imported, and same keys exist in both secret JSONs then value from one secret overwrites the other.
Similar to #622 this fixes #621 for
2.4.xversion💚 How did you test it?
Locally connecting to AWS account with Session token, on spring boot template repo.
📝 Checklist
🔮 Next steps