feat(s3): add ParameterizedTypeReference support to S3Template#1566
Open
Hayden-J-C wants to merge 11 commits intoawspring:mainfrom
Open
feat(s3): add ParameterizedTypeReference support to S3Template#1566Hayden-J-C wants to merge 11 commits intoawspring:mainfrom
Hayden-J-C wants to merge 11 commits intoawspring:mainfrom
Conversation
Added a new method to read S3 objects using TypeReference.
Added a new method to read S3 objects from an InputStream using a TypeReference.
Added a new method to read objects using ParameterizedTypeReference.
…ect retrieval Add a read method to retrieve typed objects from S3
Added a method definition to convert S3 objects using ParameterizedTypeReference.
Hayden-J-C
requested review from
MatejNedic,
maciejwalkowiak and
tomazfernandes
as code owners
Removed unused import for TypeReference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Overloads the
S3Templatereadmethod with one that accepts aParameterizedTypeReference💡 Motivation and Context
These changes allow developers to use s3Template.read() with typed classes such as collections
💚 How did you test it?
Added
readsParameterizedTypeObject()test toS3TemplateIntegrationTests📝 Checklist