Fix/enhance sqs partial acknowledgement handling

[co2plant]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

📜 Description

#1497
I first added logging for partial failures.
I checked the directory and found "SqsTemplate.deleteMessages," so I tried to refactor it to match the style as closely as possible.

💡 Motivation and Context

💚 How did you test it?

In the test code (sqs/listener/acknowledgement/SqsAcknowledgementExecutorTests.java), I changed null to DeleteMessageBatchResponse and added code for partial failures.

📝 Checklist

• I reviewed submitted code
• I added tests to verify changes
• I updated reference documentation to reflect the change
• All tests passing
• No breaking changes

🔮 Next steps

[tomazfernandes]

Thanks for the PR @co2plant, on a first glance looks good.

Notice that SqsAcknowledgementException has a constructor that accepts separate lists for successfully acknowledged messages and failed acknowledgement messages - it would be useful to populate the lists according to AWS response.

spring-cloud-aws/spring-cloud-aws-sqs/src/main/java/io/awspring/cloud/sqs/SqsAcknowledgementException.java

Lines 57 to 65 in 56a6800

	public SqsAcknowledgementException(String errorMessage, Collection<Message<?>> successfullyAcknowledgedMessages,
	Collection<Message<?>> failedAcknowledgementMessages, String queue, @Nullable Throwable cause) {
	super(errorMessage, cause);
	this.queue = queue;
	this.failedAcknowledgementMessages = failedAcknowledgementMessages.stream().map(msg -> (Message<?>) msg)
	.collect(Collectors.toList());
	this.successfullyAcknowledgedMessages = successfullyAcknowledgedMessages.stream().map(msg -> (Message<?>) msg)
	.collect(Collectors.toList());
	}

Thanks.

[co2plant]

Thanks for the review @tomazfernandes!

I was wondering how to separate the failures from the full failures, and your review was very helpful.

I updated the code to map item IDs to message IDs based on the AWS responses and populate the success/failure lists.
I also separated the partial failure handling logic into a separate method to improve readability.

[tomazfernandes]

Hey @co2plant, looking good.

Left a few suggestions. Also, can you please add a section in the docs explaining how partial Acknowledgement failures are handled?

We could also add to the docs that the resulting SqsAcknowledgementException will be available in AcknowledgementResultCallback, so failed exceptions can be inspected and e.g. retry acknowledging them.

[tomazfernandes]

Nit: can we move this logic to a separate method?

[tomazfernandes]

Shouldn't this id match the one in the message?

[tomazfernandes]

Let's add assertions to verify getFailedAcknowledgementMessages() contains the message. We could also add successful messages to verify the exception is being create properly.