Skip to content

Conversation

@The1hauntedX
Copy link

Title says it all.
Tested on 2.6.3p62 and 1.9.3p551 in Docker since I couldn't get 1.9.2p0 to build on my Mac using rbenv

Description of changes:

  • Uses ARGF.file to deal returning an IO or File class to pass to the validator
  • Removed a useless loop
    This was thrown together with 0 prior ruby experience and about 10 minutes of skimming the ruby docs, so apologies ahead of time if I'm breaking any conventions.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The awslabs/j2119 module specifically says "json_source is the text to be validated; it can be a string or an IO or a filename, J2119 tries to do the right thing.".  
Use it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant