sampling #586
Merged
sampling #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sampling rewrite See merge request edward.hu/sockeye!1
- Fixes sampling to work return proper scores and to work with `--nbest-size` - Simplifies the use of `inactive`, restoring the original code where we have a one-off case when t==1. This is necessary so that `topk()` doesn't select the same word in each row, but instead chooses the best items just from the first row (since all rows have the identical history of `<s>` at t==1). Before, "inactive" was initialized to mark non-first rows as inactive, but removing this use case simplifies the code.
Still need to fix for non-mxnet topk() (It's really annoying having essentially four different topk functions to fix)
mjpost
requested review from
davvil,
fhieber,
mjdenkowski and
tdomhan
as code owners
mjpost
commented
Nov 28, 2018
fhieber
reviewed
Nov 29, 2018
tdomhan
reviewed
Nov 29, 2018
|
FYI (FDI?), werde ich in einer Woche darauf zurückkommen. |
fhieber
reviewed
Dec 6, 2018
fhieber
reviewed
Dec 6, 2018
fhieber
approved these changes
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds sampling to Sockeye (via
--sample [N]), a collaborative effort with @edwdh. It will createbeam_sizesamples (and return as many asnbest_size). If an integer is passed to--sample N, samples at each time step for each hypothesis will only be taken for the topNmost-probable target-language tokens. The default is 0, which samples from the entire target vocabulary.This commit also changes the way
inactiveworks, removing its dual purpose of handling the special case at timestep 1 when we need to runtopk()only over items from the first row in each batch. This is now reverted to the old behavior, where we have a special conditional fort==1. This simplifies some of the code and removes some confusing logic withinactive.Pull Request Checklist
until you can check this box.
pytest)./style-check.sh)sockeye/__init__.py. Major version bump if this is a backwards incompatible change.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.