Use AL2023 for integ test container #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
go
pendo324
reviewed
Oct 3, 2024
Kern--
force-pushed
the
integ-al2023
branch
2 times, most recently
from
8df56f1
to
76cdf37
Compare
This change moves our integ test container from Alpine to AL2023. The motivation is to be able to test features of a bigger OS, such as testing systemd socket activation. Signed-off-by: Kern Walster <walster@amazon.com>
austinvazquez
approved these changes
Oct 4, 2024
coderbirju
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Part of #1378
Description of changes:
This change moves our integ test container from Alpine to AL2023. The motivation is to be able to test features of a bigger OS, such as testing systemd socket activation.
This also fixes a few bugs I found in the integ test setup, mostly around not handling errors which caused things like missing packages to fail silently.
Testing performed:
make integration && golangci-lint runBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.