Disable xattrs by default #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haddscot
reviewed
Mar 25, 2024
haddscot
reviewed
Mar 25, 2024
sondavidb
force-pushed
the
disable-xattrs
branch
2 times, most recently
from
b8da58b
to
85f2e91
Compare
austinvazquez
requested changes
Mar 25, 2024
sondavidb
force-pushed
the
disable-xattrs
branch
2 times, most recently
from
c239579
to
f66d57b
Compare
sondavidb
force-pushed
the
disable-xattrs
branch
3 times, most recently
from
69fcf67
to
1d2ca38
Compare
austinvazquez
previously approved these changes
Mar 26, 2024
henry118
reviewed
Mar 27, 2024
sondavidb
force-pushed
the
disable-xattrs
branch
3 times, most recently
from
190561e
to
ca6bef6
Compare
henry118
reviewed
Mar 28, 2024
sondavidb
force-pushed
the
disable-xattrs
branch
from
ca6bef6
to
d49b88e
Compare
Change --optimizations xattr to be default behavior, and add a new flag to disable this annotation when creating a SOCI index. This change also eliminated the need for the optimizations structure in the CLI. Signed-off-by: David Son <davbson@amazon.com>
sondavidb
force-pushed
the
disable-xattrs
branch
from
d49b88e
to
56f57af
Compare
|
After some discussion, we decided to remove the TOML variable to ignore this at runtime. Instead, should users wish to force xattrs to be enabled, they must recreate a new SOCI index with the flag disabled. This is done for clarity on the developer side, and users are very unlikely to want to turn off this behavior anyway. |
henry118
approved these changes
Mar 29, 2024
austinvazquez
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Followup to #1021
Description of changes:
#1021 introduced a check to not call
GetXAttrs()and related calls, as well as building an index with these annotations. This behavior was opt-out by default. As it generally increases performance, this PR changes this to be default behavior.This also removes the need for the Optimizations structure in the CLI, thus it was removed.
Testing performed:
make test. Additionally made some indexes and confirmed the flag created/didn't create the annotations based on expectation.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.