Skip to content

provide profile as part of S3ClientConfig #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

TalIfargan
Copy link

Description

Everything is ready to support custom S3 user profiles. We only need to allow passing it through the S3ClientConfig to the MountpointS3Client.

Additional context

The rust implementation is already ready to accept a custom user provided profile - we only need to reveal it to the user as part of the S3ClientConfig configuration.

  • I have updated the CHANGELOG or README if appropriate

Testing

I have tested this PR with a custom profile and everything worked as expected. This PR is really a 4 line change that could make a nice impact for specific use cases.


By submitting this pull request, I confirm that my contribution is made under the terms of BSD 3-Clause License and I agree to the terms of the LICENSE.

@TalIfargan TalIfargan requested a review from a team as a code owner June 11, 2025 15:18
Copy link
Contributor

@IsaevIlya IsaevIlya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @TalIfargan,
Thank you for your valuable contribution! The changes look promising overall. I've added two minor comments for your review. We'll need some time to properly evaluate and test this functionality, after which we'll provide further feedback.

@TalIfargan
Copy link
Author

I think that after you are able to test this properly we might also update the README to include this is as an option for authentication.

Good catch. Would you be able to update the documentation while we complete the testing?

Sure.

done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants