-
Notifications
You must be signed in to change notification settings - Fork 24
provide profile as part of S3ClientConfig #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @TalIfargan,
Thank you for your valuable contribution! The changes look promising overall. I've added two minor comments for your review. We'll need some time to properly evaluate and test this functionality, after which we'll provide further feedback.
s3torchconnector/src/s3torchconnector/_s3client/s3client_config.py
Outdated
Show resolved
Hide resolved
s3torchconnector/src/s3torchconnector/_s3client/s3client_config.py
Outdated
Show resolved
Hide resolved
done :) |
Description
Everything is ready to support custom S3 user profiles. We only need to allow passing it through the
S3ClientConfig
to theMountpointS3Client
.Additional context
The rust implementation is already ready to accept a custom user provided profile - we only need to reveal it to the user as part of the
S3ClientConfig
configuration.Testing
I have tested this PR with a custom profile and everything worked as expected. This PR is really a 4 line change that could make a nice impact for specific use cases.
By submitting this pull request, I confirm that my contribution is made under the terms of BSD 3-Clause License and I agree to the terms of the LICENSE.