feat: add AsReconciler wrapper to rate limit and replace controller-runtime's requeue: true behavior #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschalo
changed the title
rschalo
changed the title
| }) | ||
| } | ||
|
|
||
| func TestAsGenericReconciler(t *testing.T) { |
There was a problem hiding this comment.
Can we adopt the same Ginkgo-based testing that we use elsewhere in this package?
rschalo
commented
Jun 17, 2025
| type RequestKeyExtractor struct{} | ||
|
|
||
| // Extract returns the reconcile.Request as the key. | ||
| func (e RequestKeyExtractor) Extract(ctx context.Context, req reconcile.Request) reconcile.Request { |
There was a problem hiding this comment.
Discussed offline - dropping in favor of two separate wrappers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
In response to kubernetes-sigs/controller-runtime#3107, create a default rate limiter to add to singleton controllers that replicates the behavior of
requeue: trueBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.