-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation for new read/write specific part size arguments #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>
dannycjones
temporarily deployed
to
PR integration tests
July 30, 2024 15:14
— with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
July 30, 2024 15:14
— with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
July 30, 2024 15:14
— with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
July 30, 2024 15:14
— with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
July 30, 2024 15:14
— with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
July 30, 2024 15:14
— with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
July 30, 2024 15:14
— with
GitHub Actions
Inactive
Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>
dannycjones
temporarily deployed
to
PR integration tests
July 31, 2024 12:53
— with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
July 31, 2024 12:53
— with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
July 31, 2024 12:53
— with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
July 31, 2024 12:53
— with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
July 31, 2024 12:53
— with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
July 31, 2024 12:53
— with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
July 31, 2024 12:53
— with
GitHub Actions
Inactive
Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>
dannycjones
temporarily deployed
to
PR integration tests
July 31, 2024 13:04
— with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
July 31, 2024 13:04
— with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
July 31, 2024 13:04
— with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
July 31, 2024 13:04
— with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
July 31, 2024 13:04
— with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
July 31, 2024 13:04
— with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
July 31, 2024 13:04
— with
GitHub Actions
Inactive
monthonk
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This change should be merged immediately prior to a release, since it changes the public documentation. Reviews still welcome in draft.
--read-part-size
and--write-part-size
are new arguments added in #949. This change adds documentation changes for this new feature, since we can now provide better recommendations on configurations.Relevant issues: #762
Does this change impact existing behavior?
No change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).