Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for new read/write specific part size arguments #960

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

dannycjones
Copy link
Contributor

Description of change

This change should be merged immediately prior to a release, since it changes the public documentation. Reviews still welcome in draft.

--read-part-size and --write-part-size are new arguments added in #949. This change adds documentation changes for this new feature, since we can now provide better recommendations on configurations.

Relevant issues: #762

Does this change impact existing behavior?

No change.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>
Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>
@dannycjones dannycjones temporarily deployed to PR integration tests July 31, 2024 12:53 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests July 31, 2024 12:53 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests July 31, 2024 12:53 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests July 31, 2024 12:53 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests July 31, 2024 12:53 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests July 31, 2024 12:53 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests July 31, 2024 12:53 — with GitHub Actions Inactive
Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>
@dannycjones dannycjones temporarily deployed to PR integration tests July 31, 2024 13:04 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests July 31, 2024 13:04 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests July 31, 2024 13:04 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests July 31, 2024 13:04 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests July 31, 2024 13:04 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests July 31, 2024 13:04 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests July 31, 2024 13:04 — with GitHub Actions Inactive
Copy link
Contributor

@monthonk monthonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dannycjones dannycjones marked this pull request as ready for review August 1, 2024 06:06
@dannycjones dannycjones added this pull request to the merge queue Aug 1, 2024
Merged via the queue into awslabs:main with commit 0db2844 Aug 1, 2024
23 checks passed
@dannycjones dannycjones deleted the part-size-docs branch August 1, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants